Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): should be able to not clear search value in multiple mode, close #3590 #4845

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

FairyYang
Copy link
Collaborator

fix(Select): should be able to select multiple options in multi-select, close #3590

Copy link

你好,该 pr 已 30 天没有活动,因此被标记为 stale,如果之后的 7 天仍然没有活动,该 pr 将被自动关闭

@github-actions github-actions bot added the Stale not active for a lone time label Jun 14, 2024
@FairyYang
Copy link
Collaborator Author

FairyYang commented Jun 14, 2024 via email

@github-actions github-actions bot removed the Stale not active for a lone time label Jun 15, 2024
@eternalsky eternalsky self-requested a review June 20, 2024 11:47
components/select/select.tsx Outdated Show resolved Hide resolved
@eternalsky eternalsky changed the title fix(Select): should be able to select multiple options in multi-select, close #3590 fix(Select): should be able to not clear search value in multiple mode, close #3590 Jun 20, 2024
@FairyYang FairyYang closed this Jun 24, 2024
@FairyYang FairyYang reopened this Jun 24, 2024
components/select/types.ts Show resolved Hide resolved
components/select/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
@FairyYang
Copy link
Collaborator Author

1、提交了新的commit,测试行为的修改去掉了。
2、autoClearSearchValue默认为false的话,需要修改原有的测试用例,因为原有的组件行为,默认会清空搜索。所以autoClearSearchValue默认为true比较合理。

@eternalsky eternalsky merged commit ab017bc into alibaba-fusion:master Jul 1, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants