refactor(Upload): convert to TypeScript, impove docs and tests, close #4622 #4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
FairyYang
changed the title
eternalsky
requested changes
May 29, 2024
FairyYang
force-pushed
the
form-update
branch
2 times, most recently
from
6e7820e
to
4abb28c
Compare
eternalsky
reviewed
Jun 20, 2024
eternalsky
requested changes
Jun 20, 2024
|
重新提交了一版 |
|
重新打开PR |
eternalsky
requested changes
Jun 26, 2024
| @@ -194,7 +169,7 @@ class Card extends Base { | |||
| listType="card" | |||
| closable | |||
| locale={locale} | |||
| value={this.state.value} | |||
| value={this.state.value as UploadFile[]} | |||
There was a problem hiding this comment.
state.value 本身不就是 UploadFile[] 吗，这里为什么还需要 as
|
提交了一个commit，修复了上面的问题 |
eternalsky
requested changes
Jul 1, 2024
| @@ -194,7 +169,7 @@ class Card extends Base { | |||
| listType="card" | |||
| closable | |||
| locale={locale} | |||
| value={this.state.value} | |||
| value={this.state.value as UploadFile[]} | |||
eternalsky
requested changes
Jul 1, 2024
| const prefixCls = `${this.props.prefix}upload`; | ||
| const downloadURL = file.downloadURL || file.url; | ||
| const imgURL = file.imgURL || file.url; | ||
| const size = this.sizeCaculator(file.size); | ||
| const size = this.sizeCaculator(file.size as unknown as string); |
There was a problem hiding this comment.
那这里应该用 expect-error 并说明原因，不要出现 as unknown。
| @@ -190,16 +149,25 @@ class List extends Component { | |||
| } | |||
|
|
|||
| const suffix = SIZE_SUFFIX[suffixIndex]; | |||
| fileSize = fileSize.toFixed(2); | |||
| fileSize = fileSize.toFixed(2) as unknown as number; | |||
| @@ -618,7 +495,7 @@ class Upload extends Base { | |||
| actionRender={actionRender} | |||
| uploader={this} | |||
| listType={listType} | |||
| value={this.state.value} | |||
| value={this.state.value as UploadFile[]} | |||
eternalsky
requested changes
Jul 1, 2024
eternalsky
reviewed
Jul 4, 2024
| export function removeFileItem<T extends { uid?: string | number; name?: string }>( | ||
| file: T, | ||
| fileList: T[] | ||
| ) { |
There was a problem hiding this comment.
这里感觉用泛型把类型收的太窄了。从实现上来看，这个 remove 逻辑，并不要求 fileList 的 item 必须要和 file 同型，只是过滤 uid 或者 name 相等的情况。即使其他字段不相同，也是可以过滤的。而这里加了泛型之后，就要求两者类型必须完全一致了。这也是为什么下面测试里还得额外指定类型的原因了。
| }); | ||
| it('removeFileItem not find one to remove', () => { | ||
| const file = { uid: 1, 1: 1 }; | ||
| const files = [{ uid: 3, 3: 3 }, { uid: 2, 2: 2 }]; | ||
| const files: { uid: number; [key: number]: number }[] = [ |
There was a problem hiding this comment.
这里没必要指定类型，removeFileItem 那里已经做出了说明。
| const prefixCls = `${this.props.prefix}upload`; | ||
| const downloadURL = file.downloadURL || file.url; | ||
| const imgURL = file.imgURL || file.url; | ||
| const size = this.sizeCaculator(file.size); | ||
| const size = this.sizeCaculator(file.size as unknown as string); |
There was a problem hiding this comment.
那这里应该用 expect-error 并说明原因，不要出现 as unknown。
eternalsky
approved these changes
Jul 4, 2024
eternalsky
merged commit 000aa10
into
alibaba-fusion:refactor/upload
2 of 4 checks passed
eternalsky
pushed a commit
that referenced
this pull request
Jul 5, 2024
eternalsky
pushed a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4622