Migrate HTTPClient and Kmd to TypeScript #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `TransactionLike` type and `instantiateTxnIfNeeded` utility method
* Add `IntDecoding` type to TypeScript definitions
* Add lint rule to flag `module.exports` and `require` statements in TypeScript files
* Encapsulate `AlgodClient` and `IndexerClient` shared structures in an abstract class `ServiceClient`
e74a492
to
8bb0107
Compare
* Abstract `ServiceClient` functionality into rewritten `HTTPClient` * Include workaround for `algod` v1
8bb0107
to
a5c17ab
Compare
* Include some small enhancements to abstract `JSONRequest` class
# Conflicts: # src/client/v2/algod/accountInformation.ts # src/client/v2/algod/algod.ts # src/client/v2/algod/block.ts # src/client/v2/algod/compile.ts # src/client/v2/algod/dryrun.ts # src/client/v2/algod/getApplicationByID.ts # src/client/v2/algod/getAssetByID.ts # src/client/v2/algod/pendingTransactionInformation.ts # src/client/v2/algod/pendingTransactions.ts # src/client/v2/algod/pendingTransactionsByAddress.ts # src/client/v2/algod/proof.ts # src/client/v2/algod/sendRawTransaction.ts # src/client/v2/algod/statusAfterBlock.ts # src/client/v2/algod/supply.ts # src/client/v2/indexer/indexer.ts # src/client/v2/indexer/lookupAccountByID.ts # src/client/v2/indexer/lookupAccountTransactions.ts # src/client/v2/indexer/lookupApplications.ts # src/client/v2/indexer/lookupAssetBalances.ts # src/client/v2/indexer/lookupAssetByID.ts # src/client/v2/indexer/lookupAssetTransactions.ts # src/client/v2/indexer/lookupBlock.ts # src/client/v2/indexer/lookupTransactionByID.ts # src/client/v2/indexer/searchForTransactions.ts # src/client/v2/jsonrequest.ts # src/main.ts # src/utils/utils.ts
52f40a2
to
927f10c
Compare
ServiceClient, which includes an HTTPClient property, allows overwriting the HTTPClient instance. This functionality is required by: #277 (comment)
jasonpaulos
suggested changes
Mar 30, 2021
* Remove HTTPClient workaround in `src/client/algod.js` * Add `IndexerTokenHeader` interface * Remove extraneous IntEncoding getters/setters
* Fix `MKD` typo
jasonpaulos
suggested changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #305.