fix: use the actions/github-script action instead of the deprecated actions/github action
#934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `actions/github` action
Haroenv
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub Actions jobs created by
shipjs setupuse theactions/githubaction. But theactions/githubaction is deprecated and it is recommended to use theactions/github-scriptaction instead.https://github.com/actions/github
So I've fixed the generated jobs to use
actions/github-script.https://github.com/miyajan/test-shipjs/pull/1
I have tested the fixed
create_done_commentandcreate_fail_commentjobs on my test repository to make sure they work correctly.