Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shipjs): do not include __tests__ directory #802

Merged
merged 1 commit into from
May 8, 2020

Conversation

tyankatsu0105
Copy link
Contributor

This is not good...
スクリーンショット 2020-05-07 22 12 58

files key in package.json can select that not to include directory.
like this!!
https://github.com/stylelint/stylelint/blob/master/package.json#L33

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some people explicitly leave the tests in, but it makes sense to disable them too I think

@tyankatsu0105
Copy link
Contributor Author

@Haroenv

Some people explicitly leave the tests

Oh really?
I've never seen that.
Why people leave test files?

@eunjae-lee eunjae-lee merged commit e28e0ee into algolia:master May 8, 2020
@tyankatsu0105 tyankatsu0105 deleted the chore/not-include-test branch May 8, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants