fix(shipjs-lib): exclude dependencies from final bundle #651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @eunjae-lee 🙌🏻
some dependencies install twice for shipjs-lib, first install as a regular deps, second bundled in
shipjs-lib
with rollup, as resultshipjs-lib
30% bigger than shall beI exclude all dependencies from bundle and convert all
require
toimport
, that should fix duplicationPS. shelljs fails because have circular dependencies
shell.js
importssrc/common.js
src/common.js
importsshell.js
it works nice in node, but when bundled into 1 file don't