Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shipjs-lib): exclude dependencies from final bundle #651

Merged
merged 3 commits into from
Mar 6, 2020

Conversation

jeetiss
Copy link
Contributor

@jeetiss jeetiss commented Feb 1, 2020

Hello @eunjae-lee 🙌🏻

some dependencies install twice for shipjs-lib, first install as a regular deps, second bundled in shipjs-lib with rollup, as result shipjs-lib 30% bigger than shall be

I exclude all dependencies from bundle and convert all require to import, that should fix duplication

PS. shelljs fails because have circular dependencies

  • shell.js imports src/common.js
  • src/common.js imports shell.js
  • 💥💥💥

it works nice in node, but when bundled into 1 file don't

@eunjae-lee
Copy link
Contributor

Thanks! I'll look into this :)

@eunjae-lee eunjae-lee merged commit f6ec4cf into algolia:master Mar 6, 2020
@jeetiss jeetiss deleted the fix-deps-duplication branch March 6, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants