Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(setup): add github actions as CI option #502

Merged
merged 23 commits into from
Dec 20, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
jeetiss committed Dec 7, 2019
commit fe2d8b0aab75169d736c6547c863b726399d2b69
2 changes: 1 addition & 1 deletion packages/shipjs/src/flow/setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ async function setup({ help = false, dir = '.', dryRun = false }) {
dir,
dryRun,
}),
await integrations[CIIndex].addConfig({
integrations[CIIndex].addConfig({
...CIConfig,
isScoped,
isPublic,
Expand Down
3 changes: 0 additions & 3 deletions packages/shipjs/src/step/setup/CI/addGithubActions.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ export default ({ releaseBranch, manualPrepare, dir, dryRun }) =>
manualPrepare &&
createGithubAction({
content: getManualPrepareConfig({
releaseBranch,
dir,
dryRun,
gitUserName,
gitUserEmail,
}),
Expand Down