feat(setup): add --dry-run flag
#492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeetiss
changed the title
--dry-fun flag for setup step--dry-run flag to setup step
eunjae-lee
changed the title
--dry-run flag to setup step--dry-run flag
|
This was indeed a missing part. Thanks! FYI, you can run your change over another test repository like the following: yarn workspace shipjs test:run:setup --dir ~/workspace/your-test-repositoryhttps://github.com/algolia/shipjs/pull/397/files#diff-426ef58fea240262e72d6804380e2bc4R40 |
eunjae-lee
reviewed
Dec 3, 2019
| json.scripts['release:prepare'] = 'shipjs prepare'; | ||
| json.scripts['release:trigger'] = 'shipjs trigger'; | ||
| fs.writeFileSync(filePath, `${JSON.stringify(json, null, 2)}\n`); | ||
| await runPrettier({ filePath, dir }); |
There was a problem hiding this comment.
await → nice catch. Thanks 👍
eunjae-lee
suggested changes
Dec 3, 2019
There was a problem hiding this comment.
Seems nice!
Can you add a description for --dry-run option to shipjs setup --help?
You can refer to this: https://github.com/algolia/shipjs/blob/master/packages/shipjs/src/step/prepare/printHelp.js#L12:L12
eunjae-lee
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for testing #489