Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detecting yarn in setup script #381

Merged
merged 1 commit into from
Oct 31, 2019
Merged

fix: detecting yarn in setup script #381

merged 1 commit into from
Oct 31, 2019

Conversation

jeetiss
Copy link
Contributor

@jeetiss jeetiss commented Oct 31, 2019 •
edited

detectYarn is function, but used as Boolean

Fixed that

Haroenv
Haroenv approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, happy hacktoberfest!

@eunjae-lee eunjae-lee changed the title Fix detecting yarn in setup script fix: detecting yarn in setup script Oct 31, 2019
@eunjae-lee eunjae-lee merged commit 7aa393a into algolia:master Oct 31, 2019
@eunjae-lee eunjae-lee mentioned this pull request Oct 31, 2019
Merged
@jeetiss jeetiss deleted the fix-detexting-yarn branch December 28, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeetiss @Haroenv @eunjae-lee