Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chore): warn appropriately on supplying invalid flags #380

Merged
merged 6 commits into from
Nov 2, 2019
Merged

fix(chore): warn appropriately on supplying invalid flags #380

merged 6 commits into from
Nov 2, 2019

Conversation

jamesgeorge007
Copy link
Contributor

closes #379

Haroenv
Haroenv reviewed Oct 31, 2019
View reviewed changes
packages/shipjs/src/cli.js Outdated Show resolved Hide resolved
@eunjae-lee eunjae-lee merged commit bff3a3b into algolia:master Nov 2, 2019
@eunjae-lee
Copy link
Contributor

@jamesgeorge007 congrats 🎉
Thanks for your contribution.
If you want yourself on the contributors list,
you can simply create a PR for that.
You can update the list by running the following command:

yarn contributors:add jamesgeorge007 code

@jamesgeorge007 jamesgeorge007 deleted the hotfix/handle-invalid-flags branch November 3, 2019 03:18
@jamesgeorge007
Copy link
Contributor Author

#387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunjae-lee eunjae-lee eunjae-lee left review comments

@Haroenv Haroenv Haroenv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle the errors thrown while supplying invalid flags
3 participants
@jamesgeorge007 @eunjae-lee @Haroenv