fix(github): update parameters used during upload of release assets #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why the license/security synk tests fail |
francoischalifour
approved these changes
Apr 12, 2023
Haroenv
requested changes
Apr 12, 2023
francoischalifour
approved these changes
Apr 12, 2023
Haroenv
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Octokit package powering ShipJS' integration with Github changed the parameters required for uploading a release asset. This change occurred between Octokit's v16 and v17.
ShipJS currently runs on top of v17 of the Octokit package. This means that the method in charge of uploading release assets is broken.
This PR updates this method so its compatible with v17 of the Octokit package.
The PR also includes tests associated with the upload of release assets.