fix(slack): use tag name instead of release tag (#609)

Co-authored-by: Eunjae Lee <[email protected]>
algolia · Jan 14, 2020 · f183425 · f183425
1 parent b5e576a
commit f183425
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/packages/shipjs-lib/src/lib/config/defaultConfig.js b/packages/shipjs-lib/src/lib/config/defaultConfig.js
@@ -168,7 +168,7 @@ export default {
  releaseSuccess: ({
  appName,
  version,
- releaseTag,
+ tagName,
  latestCommitHash,
  latestCommitUrl,
  repoURL,
@@ -192,7 +192,7 @@ export default {
  },
  {
  title: 'Release',
- value: `${repoURL}/releases/tag/${releaseTag}`,
+ value: `${repoURL}/releases/tag/${tagName}`,
  },
  ],
  }),

diff --git a/packages/shipjs/src/flow/release.js b/packages/shipjs/src/flow/release.js
@@ -57,7 +57,7 @@ async function release({ help = false, dir = '.', dryRun = false }) {
  config,
  appName,
  version,
- releaseTag,
+ tagName,
  latestCommitHash,
  latestCommitUrl,
  repoURL,

diff --git a/packages/shipjs/src/step/release/notifyReleaseSuccess.js b/packages/shipjs/src/step/release/notifyReleaseSuccess.js
@@ -5,7 +5,7 @@ export default async ({
  config,
  appName,
  version,
- releaseTag,
+ tagName,
  latestCommitHash,
  latestCommitUrl,
  repoURL,
@@ -23,7 +23,7 @@ export default async ({
  config,
  appName,
  version,
- releaseTag,
+ tagName,
  latestCommitHash,
  latestCommitUrl,
  repoURL,

diff --git a/packages/shipjs/src/util/slack.js b/packages/shipjs/src/util/slack.js
@@ -65,7 +65,7 @@ export async function notifyReleaseSuccess({
  config,
  appName,
  version,
- releaseTag,
+ tagName,
  latestCommitHash,
  latestCommitUrl,
  repoURL,
@@ -81,7 +81,7 @@ export async function notifyReleaseSuccess({
  ? releaseSuccess({
  appName,
  version,
- releaseTag,
+ tagName,
  latestCommitHash,
  latestCommitUrl,
  repoURL,