fix: add version in afterPublish hook (#608)

* fix: add `version` in `afterPublish` hook * test: update tests Co-authored-by: Eunjae Lee <[email protected]>
algolia · Jan 14, 2020 · 76c5591 · 76c5591
1 parent 14ebf38
commit 76c5591
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/packages/shipjs/src/flow/release.js b/packages/shipjs/src/flow/release.js
@@ -49,7 +49,7 @@ async function release({ help = false, dir = '.', dryRun = false }) {
  runBuild({ isYarn, config, dir, dryRun });
  await runBeforePublish({ config, dir, dryRun });
  runPublish({ isYarn, config, releaseTag, dir, dryRun });
- await runAfterPublish({ config, dir, dryRun });
+ await runAfterPublish({ version, config, dir, dryRun });
  const { tagName } = createGitTag({ version, config, dir, dryRun });
  gitPush({ tagName, config, dir, dryRun });
  await createGitHubRelease({ version, config, dir, dryRun });

diff --git a/packages/shipjs/src/step/release/__tests__/runAfterPublish.spec.js b/packages/shipjs/src/step/release/__tests__/runAfterPublish.spec.js
@@ -6,6 +6,7 @@ describe('runAfterPublish', () => {
  it('works', async () => {
  const afterPublish = jest.fn();
  await runAfterPublish({
+ version: '1.2.3',
  config: {
  afterPublish,
  },
@@ -17,6 +18,7 @@ describe('runAfterPublish', () => {
  Object {
  "dir": ".",
  "exec": undefined,
+ "version": "1.2.3",
  }
  `);
  });

diff --git a/packages/shipjs/src/step/release/runAfterPublish.js b/packages/shipjs/src/step/release/runAfterPublish.js
@@ -2,7 +2,7 @@ import runStep from '../runStep';
 import { wrapExecWithDir, print } from '../../util';
 import { info } from '../../color';
 
-export default ({ config, dir, dryRun }) =>
+export default ({ version, config, dir, dryRun }) =>
  runStep(
  {
  title: 'Running "afterPublish" callback.',
@@ -14,6 +14,6 @@ export default ({ config, dir, dryRun }) =>
  print(`-> execute ${info('afterPublish()')} callback.`);
  return;
  }
- await config.afterPublish({ exec: wrapExecWithDir(dir), dir });
+ await config.afterPublish({ exec: wrapExecWithDir(dir), dir, version });
  }
  );