Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): explicitly set typescript dev dependency to prevent issues on CSB #6260

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Jul 1, 2024

Summary

Small PR that marks typescript as an explicit dev dependency to help Codesandbox interpret TypeScript appropriately in our example sandboxes.

Result

No more problem with type being an unknown keyword and other similar errors.

@dhayab dhayab requested review from a team, sarahdayan and Haroenv and removed request for a team July 1, 2024 12:32
Copy link

codesandbox-ci bot commented Jul 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b5df63c:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

@dhayab dhayab enabled auto-merge (squash) July 1, 2024 12:42
@dhayab dhayab merged commit b872501 into master Jul 1, 2024
12 checks passed
@dhayab dhayab deleted the examples/add-typescript-devdependency branch July 1, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants