Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the signing and key providing experience for the development #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MojtabaHs
Copy link

Hi, thanks for your effort on this project. I've made some changes:

  • I've removed your development team id from the project because it is private for you and will not work for anyone without the desired certificate
  • I've added a configuration file to generate a unique identifier for anyone and each apple id. So anyone will have a unique id for every bundle and will not accidentally reserve the bundle locked to their accounts
  • I've made all modules read the API I key from one single source of truth and make it static because it doesn't make sense to have separate API keys or a dynamic one.

Thanks again.
I hope it helps

@alfianlosari
Copy link
Owner

Hi, will check this a bit later!

@MojtabaHs MojtabaHs reopened this Apr 10, 2024
@MojtabaHs
Copy link
Author

I rebased this based on your new changes and made it ready to be merged again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants