Removed Controller::notImplemented(), return 404 instead

README.md

@@ -120,9 +120,6 @@ Actions are methods of the controller. A common example might be `edit` or
 This will call the function `edit()` on `Blog` with `1` as the argument (the 
 id of the blog post to edit).
 
-If the action doesn't exist `notImplemented()` will be called instead. This 
-will throw an exception by default but can be overridden.
-
 The action name and arguments can be accessed through 
 `$this->app->getAction()` and `$this->app->getArgs()` respectively.
 
@@ -309,9 +306,6 @@ Recursively decode a previously encoded value to be rendered as HTML
 * `index()` 
 Default action
 
-* `notImplemented()` 
-Fallback action in case the called action doesn't exist
-
 
 User contributed packages
 -------------------------

Swiftlet/App.php

@@ -148,10 +148,18 @@ public function run()
  if ( $method->isPublic() && !$method->isFinal() && !$method->isConstructor() ) {
  $this->controller->{$this->action}();
  } else {
- $this->controller->notImplemented();
+ $this->controller = new Controllers\Error404($this, $this->view);
+
+ $this->view->name = 'error404';
+
+ $this->controller->index();
  }
  } else {
- $this->controller->notImplemented();
+ $this->controller = new Controllers\Error404($this, $this->view);
+
+ $this->view->name = 'error404';
+
+ $this->controller->index();
  }
 
  $this->registerHook('actionAfter');

Swiftlet/Controller.php

@@ -48,13 +48,4 @@ public function __construct(Interfaces\App $app, Interfaces\View $view)
  public function index()
  {
  }
-
- /**
- * Fallback in case action doesn't exist
- * @throws Exception
- */
- public function notImplemented()
- {
- throw new Exception('Action ' . $this->view->htmlEncode($this->app->getAction()) . ' not implemented in ' . get_called_class());
- }
 }

Swiftlet/Controllers/Error404.php

@@ -23,12 +23,4 @@ public function index()
  header('Status: 404 Not Found');
  }
  }
-
- /**
- * Not implemented action
- */
- public function notImplemented()
- {
- $this->index();
- }
 }

Swiftlet/Interfaces/Controller.php

@@ -18,10 +18,4 @@ public function __construct(App $app, View $view);
  * Default action
  */
  public function index();
-
- /**
- * Fallback in case action doesn't exist
- * @throws Exception
- */
- public function notImplemented();
 }