Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP2Location LITE support #1633

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Add IP2Location LITE support #1633

merged 4 commits into from
Oct 10, 2023

Conversation

ip2location
Copy link
Contributor

No description provided.

@ip2location
Copy link
Contributor Author

@alexreisner May we know how to fix the timeout error?

@ip2location
Copy link
Contributor Author

Hi @alexreisner, can you guide us on how to solve the timeout error?

@alexreisner
Copy link
Owner

Yes, sorry for the delay. I think the thing to do here is to add :ip2location_lite to the array on this line, to specify that the lookup doesn't make HTTP requests. (It looks like :maxmind_local should be there too, but I'll handle that separately.)

@ip2location
Copy link
Contributor Author

ip2location commented Sep 25, 2023

@alexreisner
Copy link
Owner

Thanks! I'm seeing another error, which I'm looking into. More on that shortly.

For now, two thoughts:

  • Please be sure to call super at the beginning of the setup method in the test file.
  • When I add the ip2location_ruby gem, I get NoMethodError: private method 'open' called for #<Geocoder::Lookup::Ip2location:0x0... @cache=nil>.

@alexreisner
Copy link
Owner

I think the best way to handle the error is to add gem 'ip2location_ruby' at line 10 of the Gemfile.

@ip2location
Copy link
Contributor Author

@alexreisner We have fixed the error.

@ip2location
Copy link
Contributor Author

Hi @alexreisner, can you help to review this PR?

@alexreisner alexreisner merged commit e05a5ae into alexreisner:master Oct 10, 2023
4 checks passed
@alexreisner
Copy link
Owner

Looks great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants