Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Include region on AWS lookup client config #1609

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Feature: Include region on AWS lookup client config #1609

merged 2 commits into from
Mar 3, 2023

Conversation

3zcurdia
Copy link
Contributor

@3zcurdia 3zcurdia commented Mar 3, 2023 •
edited
Loading

Changelog

  • Include region on Aws::LocationService::Client config
  • Remove region key when is nil

Why

To avoid setup region via ENV vars while its using the keys approach

@alexreisner alexreisner merged commit 590a61f into alexreisner:master Mar 3, 2023
@alexreisner
Copy link
Owner

Thanks!

@3zcurdia 3zcurdia deleted the feature/lookups/aws-location-service-region branch March 4, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3zcurdia @alexreisner