Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPInfoDB API #1324

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

ipinfodb-com
Copy link

No description provided.

@alexreisner
Copy link
Owner

Sorry for the delay on this. I'm a little hesitant to merge because IPInfoDB looks like a repackaging of IP2Location. So my question is: why would someone use IPInfoDB over IP2Location? (Reason for asking is that each new API adds a bit of time and effort to maintaining the gem so I'm limiting additions to APIs that offer access to new information, or a different pricing plan, or increased availability, etc.)

@ipinfodb-com
Copy link
Author

This integration is for IPInfoDB which is free and different from IP2Location

@alexreisner
Copy link
Owner

OK, however there are a bunch of test errors and failures. Could you please take a look at those?

@ipinfodb-com
Copy link
Author

Hi @alexreisner

We are facing the branch conflicts issue. May we know how to solve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants