Merge pull request #1444 from visoft/master

Added preferredLabelValues param for ESRI
alexreisner · Mar 23, 2020 · f67f29d · f67f29d
2 parents 5a4bee2 + 6e0c6c8
commit f67f29d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/geocoder/lookups/esri.rb b/lib/geocoder/lookups/esri.rb
@@ -47,6 +47,8 @@ def query_url_params(query)
  params[:forStorage] = for_storage_value
  end
  params[:sourceCountry] = configuration[:source_country] if configuration[:source_country]
+ params[:preferredLabelValues] = configuration[:preferred_label_values] if configuration[:preferred_label_values]
+
  params.merge(super)
  end
 

diff --git a/test/unit/lookups/esri_test.rb b/test/unit/lookups/esri_test.rb
@@ -24,6 +24,14 @@ def test_query_for_geocode_with_source_country
  assert_match %r{sourceCountry=USA}, url
  end
 
+ def test_query_for_geocode_with_preferred_label_values
+ Geocoder.configure(esri: {preferred_label_values: 'localCity'})
+ query = Geocoder::Query.new("Bluffton, SC")
+ lookup = Geocoder::Lookup.get(:esri)
+ url = lookup.query_url(query)
+ assert_match %r{preferredLabelValues=localCity}, url
+ end
+
  def test_query_for_geocode_with_token_and_for_storage
  token = Geocoder::EsriToken.new('xxxxx', Time.now + 60*60*24)
  Geocoder.configure(esri: {token: token, for_storage: true})