Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #29 #30

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Fix #29 #30

merged 3 commits into from
Dec 5, 2019

Conversation

alexlenail
Copy link
Owner

No description provided.

Copy link
Contributor

@aFewThings aFewThings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this commits that changed showConvDims part on 195 line, you need to modify showDims part also :).

AlexNet.js Outdated Show resolved Hide resolved
AlexNet.js Outdated Show resolved Hide resolved
alexlenail and others added 2 commits December 5, 2019 12:10
Co-Authored-By: EunBeenKim <[email protected]>
Co-Authored-By: EunBeenKim <[email protected]>
@alexlenail alexlenail merged commit f99ca43 into master Dec 5, 2019
@alexlenail
Copy link
Owner Author

This seems to work, in my quick anecdotal testing.

@alexlenail alexlenail deleted the Fix branch December 5, 2019 17:13
@aFewThings
Copy link
Contributor

It fixes conv dims, but still has issues in tensor dims.

sprite.position.copy( layer_object.position ).sub( new THREE.Vector3( wf(layer)/2 + 3, 0, depthFn(layer['depth'])/2 + 3 ) );

sprite.position.copy( layer_object.position ).sub( new THREE.Vector3( 0, -hf(layer)/2 - 3, depthFn(layer['depth'])/2 + 3 ) );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants