feat: Add context aware V2 API #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new v2 module requires context, so that cancellation can be propogated correctly to sub-commands. Some additional streamlining of the code to reduce the number of `exec.Execute` calls. The new behavior is covered by additional tests and the package should have 98% coverage. Signed-off-by: Lucas Roesler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new v2 module requires context, so that cancellation can be propagated correctly to sub-commands. This enables cancelling sub-command (#10) and adding timeouts (solving #9) via
context.WithTimeoutSome additional streamlining of the code to reduce the number of
exec.Executecalls.The new behavior is covered by additional tests and the package should have 98% coverage.
Closes #11
Resolves #9
Resolves #10
How Has This Been Tested?
Additional unit tests cover the new use cases.
How are existing users impacted? What migration steps/scripts do we need?
New users would need to change their import to use the new API.
Checklist:
I have:
git commit -s