-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serialization + kryo support #23
Comments
Hi Eyal, Thank you for the suggestions! Yes, definitely! Pull requests are welcome! |
@alexandrnikitin, I'm happy I could assist with the Java serialization support😎 |
Great! I think a sub project for kryo is a better option. |
👍
…On Mar 21, 2017 8:22 PM, "Alexandr Nikitin" ***@***.***> wrote:
Great! I think a sub project for kryo is a better option.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABFFOajEkmLQkzMZvP3D7UrXk6XPTFnbks5roBVpgaJpZM4MFaX0>
.
|
have you added kryo support to this bloomfilter??/ |
Not yet. As I see @eyalfa has done some work in the fork's branch https://github.com/eyalfa/bloom-filter-scala/commits/kryo_support @kdsandip Would you have time to review and continue the work? |
Hi,
currently the BloomFilter and its buffer are not serializable, can this be added?
same goes for kryo support, can be added with an optional dependency (I've actually already implemented this as part of my spark application)
another related issue, the provided to/from stream methods work one long at a time. haven't really benchmarked this but my intuition is that this is slowwwww. I suggest modify the current methods or add new ones that takes/allocates a buffer and leverage unsafe's ability to copy memory ranges (spark tungsten's style)
will you be willing to accept pull requests?
thanks,
Eyal.
The text was updated successfully, but these errors were encountered: