Fix the ConvolverNode issue (#91) (#92)

alemangui · Oct 7, 2018 · 92f0c9e · 92f0c9e
1 parent c05c441
commit 92f0c9e
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/src/Effects/Reverb.js b/src/Effects/Reverb.js
@@ -119,5 +119,18 @@ function buildImpulse() {
  impulseR[i] = (Math.random() * 2 - 1) * Math.pow(1 - n / length, this.decay);
  }
 
+ // https://github.com/alemangui/pizzicato/issues/91
+ // ConvolverNode can be associated with only one buffer.
+ // Not sure what's the best way, but we are recreating ConvolverNode
+ // when properties change to work it around.
+ if (this.reverbNode.buffer) {
+ this.inputNode.disconnect(this.reverbNode);
+ this.reverbNode.disconnect(this.wetGainNode);
+
+ this.reverbNode = Pizzicato.context.createConvolver();
+ this.inputNode.connect(this.reverbNode);
+ this.reverbNode.connect(this.wetGainNode);
+ }
+
  this.reverbNode.buffer = impulse;
-}
+}