switch to onStartupFinished #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from 1.46 onwards `onStartupFinished` can be used instead of `*` https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/v1_46.md#onstartupfinished-activation-event https://code.visualstudio.com/api/references/activation-events#onStartupFinished _To ensure a great end user experience, please use `*` activation event in your extension only when no other activation events combination works in your use-case._ This change can help with VSCode startup time.
|
Hi @jasonwilliams , I've noticed that announcement back then, and was planning to give it a try. Thank you for making it happen earlier 😄 . It should be available on the next release. Thank you |
alefragnani
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from 1.46 onwards
onStartupFinishedcan be used instead of*https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/v1_46.md#onstartupfinished-activation-event
https://code.visualstudio.com/api/references/activation-events#onStartupFinished
To ensure a great end user experience, please use
*activation event in your extension only when no other activation events combination works in your use-case.onStartupFinishedis similar to the*activation event, but it will not slow down VS Code startup.This change can help with VSCode startup time.