Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilanguage in Bookmarks. Added English and Russian language. #151

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Conversation

winitop
Copy link
Contributor

@winitop winitop commented Sep 20, 2018

To add a new language, need to create a file package.nls.{language}.json

@alefragnani
Copy link
Owner

Hi @Inter-Net-Pro ,

First of all, thanks for your PR 👍 (also in Project Manager extension) .

Just like in the Project Manager extension, what about the messages that the extension displays?

@winitop
Copy link
Contributor Author

winitop commented Sep 26, 2018

I apologize for such a pull request.
I edites a file called package.json took it from the extension in VSCode, and not from github. Only now I saw that versions differ and different indents in code.

@alefragnani
Copy link
Owner

There is no need to apologize. It happens 😄

@alefragnani alefragnani self-assigned this Oct 28, 2018
@alefragnani alefragnani added this to the 10.2.0 milestone Dec 7, 2018
@alefragnani
Copy link
Owner

Hi @Inter-Net-Pro ,

I'm finally being able to merge your PR, and I need your help for proper translation of 4 resources that has been added since you sent the PR.

Command

  • What's New

Settings

  • Background color of the decoration. Use rgba() and define transparent background colors to play well with other decorations. Ex.: rgba(21, 126, 251, 0.1)
  • Allow navigation to wrap around at the first and last bookmarks in scope (current file or all files)
  • Use a workaround for formatters like Prettier, which does not notify on document changes and messes Bookmark's Sticky behavior

I thought about using Google Translator, but I'm not confident it works as expected.

Thank you

@winitop
Copy link
Contributor Author

winitop commented Jan 8, 2019

If you can, I will leave translation here in comments.

Command

  • What's New - Что нового

Settings

Background Line Color - Фоновый цвет строки

  • Цвет фона (background) строки на которую установлена закладка. Используйте rgba(), чтобы задать прозрачные цвета фона для хорошего сочетания с другим оформлением. Пример: rgba(21, 126, 251, 0,1)

Wrap Navigation - Перенос навигации

  • Разрешить навигацию по первой и последней закладкам в области (текущий файл или все файлы)

  • Использовать обходной путь для форматировщиков таких как Prettier, который не уведомляет об изменениях документа и путает поведение прикреплённой закладки

If you need something else - always ready to help.

@alefragnani alefragnani merged commit 1c3dfd1 into alefragnani:master Jan 8, 2019
alefragnani added a commit that referenced this pull request Jan 8, 2019
@winitop
Copy link
Contributor Author

winitop commented Jan 8, 2019

Update came. Language was established. Super!

@alefragnani
Copy link
Owner

That’s great! 🎉

The Project Manager extension should be updated next week. Stay tuned...

Thank you again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants