Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse request errors #7

Merged
merged 1 commit into from
Aug 29, 2021
Merged

parse request errors #7

merged 1 commit into from
Aug 29, 2021

Conversation

aldas
Copy link
Owner

@aldas aldas commented Aug 29, 2021

parsing request returns errors as modbus error types

@codecov-commenter
Copy link

Codecov Report

Merging #7 (7eb934e) into main (cb7b0c3) will decrease coverage by 0.01%.
The diff coverage is 98.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   98.61%   98.59%   -0.02%     
==========================================
  Files          27       27              
  Lines        2096     2282     +186     
==========================================
+ Hits         2067     2250     +183     
- Misses         19       22       +3     
  Partials       10       10              
Flag Coverage Δ
unittests 98.59% <98.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packet/error.go 95.06% <86.66%> (-4.94%) ⬇️
packet/packet.go 100.00% <100.00%> (ø)
packet/readcoilsrequest.go 100.00% <100.00%> (ø)
packet/readdiscreteinputsrequest.go 100.00% <100.00%> (ø)
packet/readholdingregistersrequest.go 100.00% <100.00%> (ø)
packet/readinputregistersrequest.go 100.00% <100.00%> (ø)
packet/readwritemultipleregistersrequest.go 100.00% <100.00%> (ø)
packet/writemultiplecoilsrequest.go 100.00% <100.00%> (ø)
packet/writemultipleregistersrequest.go 100.00% <100.00%> (ø)
packet/writesinglecoilrequest.go 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7b0c3...7eb934e. Read the comment docs.

@aldas aldas merged commit c41cbf4 into main Aug 29, 2021
@aldas aldas deleted the request_parsing branch August 29, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants