Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua linking issue on modern systems #808

Open
lxkurko opened this issue Feb 20, 2017 · 0 comments
Open

Lua linking issue on modern systems #808

lxkurko opened this issue Feb 20, 2017 · 0 comments

Comments

@lxkurko
Copy link
Contributor

lxkurko commented Feb 20, 2017 •
edited
Loading

If LIBLUA_BUILTIN is not set, Cmake searches for "lua", then "lua5.1" and if neither is found, defaults to "lua" when setting up linking. But on some modern systems, searching for "lua" gives a newer version such as 5.3 which doesn't work.

Also, searching for "lua5.1" may not find anything (seem to be the case on Arch Linux) so reversing the search order wouldn't work, it would still use "lua".

Would it make sense to just set it to lua5.1 (until someone changes the code to use newer version)? Many systems nowadays probably have newer versions so the default "lua" would be wrong anyway. If lua5.1 doesn't work for someone, the builtin lib is always there.

edit: Also, the header directory is set to /usr/include/lua5.1 so I think it would be perfectly consistent to always use lua5.1 as linking option.
lxkurko added a commit to lxkurko/openlierox that referenced this issue May 4, 2018
@lxkurko
[CMake] Improved Lua detection - albertz#808
c061662 
The default Lua version on many systems is often newer than 5.1
However, such versions seem to be incompatible with OLX.
So search first for "lua5.1" and if it's not found,
search for "lua-5.1" - this works on Fedora, for example.
If neither is found, search for "lua" and finally use default "lua"
but give warnings and suggestions too because errors may be likely.
TODO: Header search path should be configured dynamically too.
pelya added a commit that referenced this issue May 30, 2018
@pelya
Merge pull request #816 from lxkurko/0.59
de62596 
[CMake] Improved Lua detection - #808
lxkurko added a commit to lxkurko/openlierox that referenced this issue Jul 12, 2018
@lxkurko
[CMake] Dynamic Lua header path detection - albertz#808
75898f1 
Find the Lua 5.1 header directory dynamically too.
pelya added a commit that referenced this issue Jul 13, 2018
@pelya
Merge pull request #818 from lxkurko/0.59
f3231fd 
[CMake] Improved Lua detection - find header directory too - #808
lxkurko added a commit to lxkurko/openlierox that referenced this issue Jul 20, 2018
@lxkurko
[CMake] Fix more Lua linking options - albertz#808
e8e3ba3
jamek pushed a commit to jamek/openlierox that referenced this issue Apr 9, 2019
@lxkurko @jamek
[CMake] Improved Lua detection - albertz#808
c0c9891 
The default Lua version on many systems is often newer than 5.1
However, such versions seem to be incompatible with OLX.
So search first for "lua5.1" and if it's not found,
search for "lua-5.1" - this works on Fedora, for example.
If neither is found, search for "lua" and finally use default "lua"
but give warnings and suggestions too because errors may be likely.
TODO: Header search path should be configured dynamically too.
jamek pushed a commit to jamek/openlierox that referenced this issue Apr 9, 2019
@lxkurko @jamek
[CMake] Dynamic Lua header path detection - albertz#808
7db8a03 
Find the Lua 5.1 header directory dynamically too.
jamek pushed a commit to jamek/openlierox that referenced this issue Apr 9, 2019
@lxkurko @jamek
[CMake] Fix more Lua linking options - albertz#808
6c9caef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lxkurko