Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and replace outdated packages #153

Closed
wants to merge 12 commits into from

Conversation

PrettyCoffee
Copy link

Hey, this PR is tackling the upgrade discussed in #151.

Unfortunately, I wasn't able to split it into several PRs, since there are too many co-dependencies (especially doing anything related to a newer node version)

I think we got 3 options for how to proceed with this:

  1. You review this monstrosity of a PR
  2. If you don't mind a temporary broken state, we could also split this PR into multiple parts that take care of fixing and modernizing one part at a time (e.g. eslint -> msw -> vite -> vitest etc)
  3. We create an migration branch, remove some things to have a minimal state and then start adding part by part back

I tested all available scripts and everything seems to be working. (On windows)
That being said, I am not familiar with all of the installed packages and I also wasn't able to run the project in its original state.

Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for bulletproof-react-app failed.

Name Link
🔨 Latest commit 0fa3d8f
🔍 Latest deploy log https://app.netlify.com/sites/bulletproof-react-app/deploys/662e88c62ee83a0008aa2b77

@alan2207
Copy link
Owner

hey @PrettyCoffee , thanks a lot for putting this together. Funny thing, I also started migrating stuff yesterday and here is my draft PR: #152 . Besides a couple of flaky tests, everything else is in place and working. I will review your PR as well and see which one fits more to be merged.

alan2207 added a commit that referenced this pull request May 1, 2024
alan2207 added a commit that referenced this pull request May 14, 2024
@alan2207
Copy link
Owner

Hey @PrettyCoffee , thanks again for making the effort to submit this huge PR. I went through your changes and added some good things from this PR into #152 . Everything should be updated now with more modern stack, and other improvements.

@alan2207 alan2207 closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants