-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't auto-fix when linting client #1467
Comments
gabemart
added a commit
that referenced
this issue
Jun 14, 2018
1 task
gabemart
added a commit
that referenced
this issue
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we have
npm run lint
set to autofix where possibleI think this is leading to slight weirdness - if you merge something that is auto-fixable without actually running lint locally, it will pass CI (because the CI will auto-fix when it runs the lint step) but the actual code as-merged is not linted
I suggest we go back to the old system of
npm run lint
simply running the linter and returning a pass/fail, andnpm run lint:fix
running the linter with the--fix
flagThe text was updated successfully, but these errors were encountered: