Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't auto-fix when linting client #1467

Closed
gabemart opened this issue Jun 14, 2018 · 0 comments
Closed

Don't auto-fix when linting client #1467

gabemart opened this issue Jun 14, 2018 · 0 comments
Assignees

Comments

@gabemart
Copy link
Contributor

Currently we have npm run lint set to autofix where possible

I think this is leading to slight weirdness - if you merge something that is auto-fixable without actually running lint locally, it will pass CI (because the CI will auto-fix when it runs the lint step) but the actual code as-merged is not linted

I suggest we go back to the old system of npm run lint simply running the linter and returning a pass/fail, and npm run lint:fix running the linter with the --fix flag

gabemart added a commit that referenced this issue Jun 18, 2018
gabemart added a commit that referenced this issue Jun 18, 2018
* [#1467] Change linter to only autofix when running lint:fix

* [#1467] Linting attempt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants