refactor(rtl-mixins): remove append flag

Make mixins work in both .component.scss, _theme.scss files w/o 'append' flag.
Apply '[dir=rtl]selector' and '[dir=rtl] selector' selectors simultaneously.

src/framework/theme/components/actions/_actions.component.theme.scss

@@ -20,8 +20,7 @@
           border-left,
           border-right,
           none!important,
-          1px solid nb-theme(actions-separator),
-          true
+          1px solid nb-theme(actions-separator)
         );
       }
 
@@ -40,8 +39,7 @@
         border-left,
         border-right,
         1px solid nb-theme(actions-separator),
-        none,
-        true
+        none
       );
       background: transparent;
     }
@@ -56,8 +54,7 @@
           border-left,
           border-right,
           1px solid nb-theme(actions-separator),
-          none,
-          true
+          none
         );
       }
     }

src/framework/theme/components/card/flip-card/_flip-card.component.theme.scss

@@ -6,6 +6,6 @@
   }
 
   .flipcard-body .front-container {
-    @include rtl-prop(margin-right, margin-left, -100%, auto, true);
+    @include rtl-prop(margin-right, margin-left, -100%, auto);
   }
 }

src/framework/theme/components/checkbox/_checkbox.component.theme.scss

@@ -35,7 +35,7 @@
 // locally used mixin
 @mixin description-style {
   color: nb-theme(color-fg-heading);
-  @include rtl-prop(padding-left, padding-right, 0.25rem, 0, true);
+  @include rtl-prop(padding-left, padding-right, 0.25rem, 0);
 }
 
 @mixin nb-checkbox-theme() {
@@ -60,7 +60,7 @@
       position: absolute;
       top: 50%;
       transform: translateY(-50%);
-      @include rtl-prop(left, right, 0, auto, true);
+      @include rtl-prop(left, right, 0, auto);
       flex: none;
       display: flex;
       justify-content: center;

src/framework/theme/components/sidebar/_sidebar.component.theme.scss

@@ -75,7 +75,7 @@
           &::before {
             position: absolute;
             content: '';
-            @include rtl-prop(left, right, 0, auto, true);
+            @include rtl-prop(left, right, 0, auto);
             top: 0;
             height: 100%;
             width: 4px;
@@ -134,19 +134,19 @@
       }
 
       &.start.fixed ~ .content {
-        @include rtl-prop(margin-left, margin-right, nb-theme(sidebar-width-compact), 0, true);
+        @include rtl-prop(margin-left, margin-right, nb-theme(sidebar-width-compact), 0);
       }
 
       &.fixed.end ~ .content {
-        @include rtl-prop(margin-right, margin-left, nb-theme(sidebar-width-compact), 0, true);
+        @include rtl-prop(margin-right, margin-left, nb-theme(sidebar-width-compact), 0);
       }
 
       &.start.fixed ~ .content.center {
-        @include rtl-prop(padding-left, padding-right, nb-theme(sidebar-width-compact), 0, true);
+        @include rtl-prop(padding-left, padding-right, nb-theme(sidebar-width-compact), 0);
       }
 
       &.fixed.end ~ .content.center {
-        @include rtl-prop(padding-right, padding-left, nb-theme(sidebar-width-compact), 0, true);
+        @include rtl-prop(padding-right, padding-left, nb-theme(sidebar-width-compact), 0);
       }
     }
 

src/framework/theme/styles/core/_mixins.scss

@@ -194,56 +194,35 @@
   }
 }
 
-@mixin rtl-prop($ltr-prop, $rtl-prop, $value, $reset-value: null, $append: false) {
+@mixin rtl-prop($ltr-prop, $rtl-prop, $value, $reset-value: null) {
   #{$ltr-prop}: $value;
 
-  @if $append == true {
-    @at-root #{selector-append('[dir=rtl]', &)} {
-      #{$ltr-prop}: $reset-value;
-      #{$rtl-prop}: $value;
-    }
-  } @else {
-    [dir=rtl] & {
-      #{$ltr-prop}: $reset-value;
-      #{$rtl-prop}: $value;
-    }
+  @at-root #{selector-append('[dir=rtl]', &)},
+  [dir=rtl] & {
+    #{$ltr-prop}: $reset-value;
+    #{$rtl-prop}: $value;
   }
 }
 
-@mixin rtl($prop, $ltr-value, $rtl-value, $append: false) {
+@mixin rtl($prop, $ltr-value, $rtl-value) {
   #{$prop}: $ltr-value;
 
-  @if $append == true {
-    @at-root #{selector-append('[dir=rtl]', &)} {
-      #{$prop}: $rtl-value;
-    }
-  } @else {
-    [dir=rtl] & {
-      #{$prop}: $rtl-value;
-    }
+  @at-root #{selector-append('[dir=rtl]', &)},
+  [dir=rtl] & {
+    #{$prop}: $rtl-value;
   }
 }
 
-@mixin rtl-only($prop, $value, $append: false) {
-  @if $append == true {
-    @at-root #{selector-append('[dir=rtl]', &)} {
-      #{$prop}: $value;
-    }
-  } @else {
-    [dir=rtl] & {
-      #{$prop}: $value;
-    }
+@mixin rtl-only($prop, $value) {
+  @at-root #{selector-append('[dir=rtl]', &)},
+  [dir=rtl] & {
+    #{$prop}: $value;
   }
 }
 
-@mixin ltr-only($prop, $value, $append: false) {
-  @if $append == true {
-    @at-root #{selector-append(':not([dir=rtl])', &)} {
-      #{$prop}: $value;
-    }
-  } @else {
-    :not([dir=rtl]) & {
-      #{$prop}: $value;
-    }
+@mixin ltr-only($prop, $value) {
+  @at-root #{selector-append(':not([dir=rtl])', &)},
+  :not([dir=rtl]) & {
+    #{$prop}: $value;
   }
 }

src/framework/theme/styles/global/bootstrap/_button-group.scss

@@ -98,31 +98,27 @@
         border-top-left-radius,
         border-top-right-radius,
         nb-theme(btn-border-radius),
-        0,
-        true
+        0
       );
       @include rtl-prop(
         border-bottom-left-radius,
         border-bottom-right-radius,
         nb-theme(btn-border-radius),
-        0,
-        true
+        0
       );
     }
     &:last-child {
       @include rtl-prop(
         border-top-right-radius,
         border-top-left-radius,
         nb-theme(btn-border-radius),
-        0,
-        true
+        0
       );
       @include rtl-prop(
         border-bottom-right-radius,
         border-bottom-left-radius,
         nb-theme(btn-border-radius),
-        0,
-        true
+        0
       );
     }
   }
@@ -133,17 +129,15 @@
         border-top-left-radius,
         border-top-right-radius,
         nb-theme(btn-border-radius),
-        0,
-        true
+        0
       );
     }
     & > .btn:last-of-type.dropdown-toggle {
       @include rtl-prop(
         border-top-right-radius,
         border-top-left-radius,
         nb-theme(btn-border-radius),
-        0,
-        true
+        0
       );
     }
 
@@ -153,17 +147,15 @@
           border-bottom-left-radius,
           border-bottom-right-radius,
           nb-theme(btn-border-radius),
-          0,
-          true
+          0
         );
       }
       & > .btn:last-of-type.dropdown-toggle {
         @include rtl-prop(
           border-bottom-right-radius,
           border-bottom-left-radius,
           nb-theme(btn-border-radius),
-          0,
-          true
+          0
         );
       }
     }
@@ -180,17 +172,15 @@
         border-bottom-left-radius,
         border-bottom-right-radius,
         nb-theme(btn-border-radius),
-        0,
-        true
+        0
       );
     }
     & > .btn:last-of-type.dropdown-toggle {
       @include rtl-prop(
         border-bottom-right-radius,
         border-bottom-left-radius,
         nb-theme(btn-border-radius),
-        0,
-        true
+        0
       );
     }
 
@@ -200,17 +190,15 @@
           border-top-left-radius,
           border-top-right-radius,
           nb-theme(btn-border-radius),
-          0,
-          true
+          0
         );
       }
       & > .btn:last-of-type.dropdown-toggle {
         @include rtl-prop(
           border-top-right-radius,
           border-top-left-radius,
           nb-theme(btn-border-radius),
-          0,
-          true
+          0
         );
       }
     }
@@ -313,7 +301,7 @@
 
   .btn-divided-group {
     .btn:not(:first-child) {
-      @include rtl-prop(margin-left, margin-right, 0.5rem, 0, true);
+      @include rtl-prop(margin-left, margin-right, 0.5rem, 0);
       border-radius: nb-theme(btn-border-radius);
     }
 

src/framework/theme/styles/global/bootstrap/_custom-forms.scss

@@ -28,7 +28,7 @@
       border: nb-theme(checkbox-border-size) solid nb-theme(checkbox-border-color);
       flex-shrink: 0;
       position: absolute;
-      @include rtl-prop(left, right, 0, auto, true);
+      @include rtl-prop(left, right, 0, auto);
       display: flex;
       justify-content: center;
       align-items: center;

src/framework/theme/styles/global/bootstrap/_dropdowns.scss

@@ -103,7 +103,7 @@
 
     .btn:first-child {
       width: 90%;
-      @include rtl(text-align, left, right, true);
+      @include rtl(text-align, left, right);
     }
 
     .dropdown-toggle {
@@ -126,15 +126,15 @@
 
   .dropdown.btn-group.show, .dropup.btn-group.show {
     .btn:first-child {
-      @include ltr-only(border-bottom-left-radius, 0, true);
-      @include rtl-only(border-bottom-right-radius, 0, true);
+      @include ltr-only(border-bottom-left-radius, 0);
+      @include rtl-only(border-bottom-right-radius, 0);
     }
   }
 
   .dropdown, .dropup {
     .dropdown-toggle {
       width: 100%;
-      @include rtl(text-align, left, right, true);
+      @include rtl(text-align, left, right);
       position: relative;
     }
 
@@ -295,7 +295,7 @@
     .dropdown-toggle::after {
       top: 50%;
       transform: translate(0, -50%);
-      @include rtl-prop(right, left, 0.75rem, auto, true);
+      @include rtl-prop(right, left, 0.75rem, auto);
     }
   }
 

src/framework/theme/styles/global/bootstrap/_icon-buttons.scss

@@ -20,12 +20,12 @@
   }
 
   .btn-with-icon {
-    @include rtl(text-align, left, right, true);
+    @include rtl(text-align, left, right);
     @include ltr-only(padding-left, 1rem);
     @include rtl-only(padding-right, 1rem);
 
     .icon {
-      @include rtl-prop(margin-right, margin-left, 1rem, 0, true);
+      @include rtl-prop(margin-right, margin-left, 1rem, 0);
     }
   }
 }

src/framework/theme/styles/global/bootstrap/_input-group.scss

@@ -19,7 +19,7 @@
     padding: 0.25rem 1rem;
     color: nb-theme(form-control-placeholder-color);
 
-    @include rtl-prop(border-right, border-left, none, $form-control-border, true);
+    @include rtl-prop(border-right, border-left, none, $form-control-border);
   }
 
   .input-group-addon {
@@ -57,16 +57,14 @@
         border-top-right-radius,
         border-top-left-radius,
         0,
-        nb-theme(form-control-border-radius),
-        true
+        nb-theme(form-control-border-radius)
       );
 
       @include rtl-prop(
         border-bottom-right-radius,
         border-bottom-left-radius,
         0,
-        nb-theme(form-control-border-radius),
-        true
+        nb-theme(form-control-border-radius)
       );
     }
     .form-control:last-child,
@@ -77,16 +75,14 @@
         border-top-left-radius,
         border-top-right-radius,
         0,
-        nb-theme(form-control-border-radius),
-        true
+        nb-theme(form-control-border-radius)
       );
 
       @include rtl-prop(
         border-bottom-left-radius,
         border-bottom-right-radius,
         0,
-        nb-theme(form-control-border-radius),
-        true
+        nb-theme(form-control-border-radius)
       );
     }