fix(overlay-trigger): performance lag after repeat in loop #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evtkhvch
changed the title
1 task
|
any updates on this PR? |
|
Some update on this? Performance within a loop is really hell. :D |
|
Anyone still working on this? We need it quite urgent 😃 |
arpansac
reviewed
Sep 8, 2022
| switchMap(() => observableFromEvent<Event>(this.document, 'click') | ||
| .pipe( | ||
| takeWhile(() => !!this.container()), | ||
| filter(event => this.isNotOnHostOrContainer(event)), |
There was a problem hiding this comment.
This needs typecasting event.target as Element
|
Can we implement a wrapper library over Nebular and create our own overlay component to patch this? I'm thinking that this is the only way right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #1467
NbClickTriggerStrategyandNbFocusTriggerStrategyISSUE:
NbTriggerStrategyBasedoesn't work as expected. It should firehide$when document is clicked.