Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): footer fixed position attribute #2694

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NicmeisteR
Copy link

The footer fixed attribute did not apply fixed positioning, although the docs in the API say it should.

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

This solves the fact that the "fixed" attribute on the Footer Layout did not apply fixed positioning.
Linked issue: #237

The footer fixed attribute did not apply fixed positioning, although the docs in the API say it should.
@NicmeisteR
Copy link
Author

Good day @Tibing! Can you please take a look at the above, it refers to issue: #237

@NicmeisteR
Copy link
Author

Any feedback on this issue?

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.78%. Comparing base (db9e556) to head (f8fdd48).
Report is 158 commits behind head on master.

Current head f8fdd48 differs from pull request most recent head a9ad036

Please upload reports for the commit a9ad036 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2694      +/-   ##
==========================================
- Coverage   77.82%   77.78%   -0.05%     
==========================================
  Files         262      262              
  Lines        8229     8227       -2     
  Branches      896      896              
==========================================
- Hits         6404     6399       -5     
- Misses       1550     1553       +3     
  Partials      275      275              

see 1 file with indirect coverage changes

@NicmeisteR
Copy link
Author

Bumping, as it's been more than a year now.

@NicmeisteR NicmeisteR mentioned this pull request May 21, 2024
2 tasks
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 31, 2024

@NicmeisteR
Copy link
Author

NicmeisteR commented Oct 31, 2024

It's been 3 years 😢

image

@NicmeisteR
Copy link
Author

Hi @nnixaa , could you please have a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant