-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(layout): footer fixed position attribute #2694
base: master
Are you sure you want to change the base?
Conversation
The footer fixed attribute did not apply fixed positioning, although the docs in the API say it should.
Any feedback on this issue? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2694 +/- ##
==========================================
- Coverage 77.82% 77.78% -0.05%
==========================================
Files 262 262
Lines 8229 8227 -2
Branches 896 896
==========================================
- Hits 6404 6399 -5
- Misses 1550 1553 +3
Partials 275 275 |
Bumping, as it's been more than a year now. |
Quality Gate failedFailed conditions |
Quality Gate passedIssues Measures |
Hi @nnixaa , could you please have a look at this? |
The footer fixed attribute did not apply fixed positioning, although the docs in the API say it should.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
This solves the fact that the "fixed" attribute on the Footer Layout did not apply fixed positioning.
Linked issue: #237