Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(badge): dot mode #2479

Merged
merged 21 commits into from
Sep 17, 2020
Merged

feat(badge): dot mode #2479

merged 21 commits into from
Sep 17, 2020

Conversation

maksim-karatkevich
Copy link
Contributor

@maksim-karatkevich maksim-karatkevich commented Aug 14, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Adds dot mode to the badge. Also, adds badge for menu items.

@ghost
Copy link

ghost commented Aug 14, 2020

Congratulations 🎉. DeepCode analyzed your code in 2.534 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@maksim-karatkevich maksim-karatkevich requested review from yggg and removed request for nnixaa August 14, 2020 07:46
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #2479 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2479   +/-   ##
=======================================
  Coverage   78.94%   78.94%           
=======================================
  Files         253      253           
  Lines        7759     7770   +11     
  Branches      852      852           
=======================================
+ Hits         6125     6134    +9     
- Misses       1369     1371    +2     
  Partials      265      265           
Impacted Files Coverage Δ
...work/theme/components/actions/actions.component.ts 96.77% <ø> (-3.23%) ⬇️
...ramework/theme/components/badge/badge.component.ts 93.47% <ø> (+0.79%) ⬆️
.../framework/theme/components/menu/menu.component.ts 75.45% <ø> (ø)
src/framework/theme/components/menu/menu.module.ts 100.00% <ø> (ø)
...rc/framework/theme/components/menu/menu.service.ts 86.86% <ø> (ø)
...mework/theme/components/tabset/tabset.component.ts 88.09% <ø> (-1.65%) ⬇️
... and 2 more

src/framework/theme/components/badge/badge.component.scss Outdated Show resolved Hide resolved
src/framework/theme/styles/themes/_mapping.scss Outdated Show resolved Hide resolved
src/framework/theme/styles/themes/_mapping.scss Outdated Show resolved Hide resolved
src/playground/with-layout/menu/menu.module.ts Outdated Show resolved Hide resolved
@yggg yggg changed the title fix(badge-enhancements): add action badge and dote mode fix(badge enhancements): add action badge and dote mode Sep 11, 2020
@yggg yggg changed the title fix(badge enhancements): add action badge and dote mode feat(badge): dot mode Sep 16, 2020
@yggg yggg merged commit afe02b7 into master Sep 17, 2020
@yggg yggg deleted the feat/badge-enhancements branch September 17, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants