Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for html content inside chat message. (#2134) #2413

Closed
wants to merge 2 commits into from
Closed

Added support for html content inside chat message. (#2134) #2413

wants to merge 2 commits into from

Conversation

pablodiazv
Copy link

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

This resolve an small feature requested by #2134
Adds support for a new type of chat message: html that allows more options to automatic chatbots to include links, buttons and other html content.

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #2413 into master will increase coverage by 0.03%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #2413      +/-   ##
==========================================
+ Coverage   81.50%   81.54%   +0.03%     
==========================================
  Files         244      245       +1     
  Lines        7382     7391       +9     
  Branches      774      774              
==========================================
+ Hits         6017     6027      +10     
+ Misses       1136     1134       -2     
- Partials      229      230       +1     
Impacted Files Coverage Δ
...rk/theme/components/chat/chat-message.component.ts 59.25% <ø> (ø)
src/framework/theme/components/chat/chat.module.ts 77.77% <ø> (ø)
...eme/components/chat/chat-message-html.component.ts 77.77% <77.77%> (ø)
...ramework/theme/components/toastr/toastr.service.ts 97.39% <0.00%> (+2.60%) ⬆️

@crates
Copy link

crates commented Apr 12, 2021

@pablodiazv / @akveo-private:

What's stopping this feature from getting merged? It's been almost a year since the initial pull request, and we REALLY need the ability to put links into messages.

@crates
Copy link

crates commented May 10, 2021

@akveo / @nnixaa / @mishkolesnikov / @Tibing / @yggg / @piotrbrzuska / @SashaSkywalker / @sashaqred / @elupanov:
Sorry to tag so many people from your team, but we really need movement on this item right away.
This is an important feature for us immediately. It looks like @pablodiazv solved it a year ago.
Is there any chance your team might be willing to quickly get this code merged to the trunk?

@Input() dateFormat: string = 'shortTime';

public get htmlMessage(): SafeHtml {
return this.sanetize.bypassSecurityTrustHtml(this.message);
Copy link
Contributor

@andreipadolin andreipadolin May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to move DomSanitizer SafeHtml into pipe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablodiazv we could merge the PR after this enhancement

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @crates, first of all much appreciate your efforts in contributing. We a releasing a new feature that allow to use custom template messages including links and other html elements within next release. Please feel free to close your PR after that feature released.

@yggg
Copy link
Contributor

yggg commented Nov 30, 2021

Closed in #2750

@yggg yggg closed this Nov 30, 2021
@pablodiazv pablodiazv deleted the chat-html-message branch December 2, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants