Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timepicker): add timepicker component #2402

Merged
merged 60 commits into from
Sep 10, 2020
Merged

feat(timepicker): add timepicker component #2402

merged 60 commits into from
Sep 10, 2020

Conversation

maksim-karatkevich
Copy link
Contributor

@maksim-karatkevich maksim-karatkevich commented Jun 3, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1168

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #2402 into master will decrease coverage by 1.52%.
The diff coverage is 58.58%.

@@            Coverage Diff             @@
##           master    #2402      +/-   ##
==========================================
- Coverage   80.46%   78.94%   -1.53%     
==========================================
  Files         244      253       +9     
  Lines        7227     7759     +532     
  Branches      793      852      +59     
==========================================
+ Hits         5815     6125     +310     
- Misses       1173     1369     +196     
- Partials      239      265      +26     
Impacted Files Coverage Δ
...eme/components/calendar-kit/calendar-kit.module.ts 100.00% <ø> (ø)
...heme/components/datepicker/datepicker.directive.ts 76.10% <ø> (ø)
...k/theme/components/datepicker/datepicker.module.ts 100.00% <ø> (ø)
...heme/components/timepicker/timepicker.directive.ts 22.95% <22.95%> (ø)
...ponents/datepicker/calendar-with-time.component.ts 45.94% <45.94%> (ø)
...amework/date-fns/services/date-fns-date.service.ts 68.75% <50.00%> (-4.59%) ⬇️
...k/theme/components/timepicker/timepicker.module.ts 50.00% <50.00%> (ø)
...lendar-kit/services/calendar-time-model.service.ts 55.17% <55.17%> (ø)
...components/datepicker/date-timepicker.component.ts 56.00% <56.00%> (ø)
...heme/components/timepicker/timepicker.component.ts 64.02% <64.02%> (ø)
... and 17 more

@maksim-karatkevich maksim-karatkevich force-pushed the feat/timepicker branch 3 times, most recently from b285caa to 8b10aad Compare July 2, 2020 13:50
@maksim-karatkevich maksim-karatkevich marked this pull request as ready for review July 13, 2020 15:45
Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, check how date-timepicker looks with size set to large

@yggg yggg merged commit 70ee391 into master Sep 10, 2020
@murbanowicz
Copy link

When is it suppose to be released? I cannot find any demo or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Time Picker
3 participants