Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Firebase auth #2385

Merged
merged 38 commits into from
Jun 3, 2020
Merged

feat: Firebase auth #2385

merged 38 commits into from
Jun 3, 2020

Conversation

mishkolesnikov
Copy link
Contributor

@mishkolesnikov mishkolesnikov commented May 27, 2020

Please read and mark the following checklist before creating a pull request:

Short description of what this resolves:

Adds a new package nebular/firebase-auth with the dependencies of firebase and angular/fire.
The package provides strategies that allow nebular/auth to work with firebase auth.
Includes password, google, facebook and twitter strategies.

@mishkolesnikov mishkolesnikov changed the title Feat/firebase auth WIP Feat/firebase auth Jun 1, 2020
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #2385 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2385      +/-   ##
==========================================
+ Coverage   81.52%   81.54%   +0.02%     
==========================================
  Files         244      244              
  Lines        7377     7382       +5     
  Branches      773      774       +1     
==========================================
+ Hits         6014     6020       +6     
+ Misses       1135     1132       -3     
- Partials      228      230       +2     
Impacted Files Coverage Δ
.../components/autocomplete/autocomplete.directive.ts 81.29% <66.66%> (-0.71%) ⬇️
...ramework/theme/components/toastr/toastr.service.ts 97.39% <0.00%> (+2.60%) ⬆️

docs/articles/auth/firebase-authentication.md Outdated Show resolved Hide resolved
docs/articles/auth/firebase-authentication.md Outdated Show resolved Hide resolved
docs/structure.ts Outdated Show resolved Hide resolved
@yggg yggg changed the title Feat/firebase auth feat: firebase auth Jun 3, 2020
@yggg yggg changed the title feat: firebase auth feat: Firebase auth Jun 3, 2020
@yggg yggg merged commit 2f75ba1 into master Jun 3, 2020
@yggg yggg deleted the feat/firebase-auth branch June 3, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants