Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept icon config in components which use nb-icon #1935

Merged
merged 11 commits into from
Aug 29, 2019
Merged

feat: accept icon config in components which use nb-icon #1935

merged 11 commits into from
Aug 29, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Aug 28, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1851
Closes #1323

@yggg yggg requested a review from nnixaa August 28, 2019 12:21
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #1935 into master will decrease coverage by 0.06%.
The diff coverage is 72.41%.

@@            Coverage Diff             @@
##           master    #1935      +/-   ##
==========================================
- Coverage   84.14%   84.08%   -0.07%     
==========================================
  Files         234      234              
  Lines        7703     7723      +20     
  Branches      675      679       +4     
==========================================
+ Hits         6482     6494      +12     
- Misses       1023     1031       +8     
  Partials      198      198
Impacted Files Coverage Δ
.../components/route-tabset/route-tabset.component.ts 83.33% <ø> (ø) ⬆️
...rc/framework/theme/components/menu/menu.service.ts 87.32% <ø> (ø) ⬆️
.../framework/theme/components/icon/icon.component.ts 96.29% <100%> (+0.94%) ⬆️
...work/theme/components/actions/actions.component.ts 100% <100%> (ø) ⬆️
...mework/theme/components/tabset/tabset.component.ts 92% <100%> (ø) ⬆️
...work/theme/components/tooltip/tooltip.component.ts 100% <100%> (ø) ⬆️
...work/theme/components/tooltip/tooltip.directive.ts 100% <100%> (ø) ⬆️
...framework/theme/components/toastr/toastr-config.ts 95.23% <100%> (ø) ⬆️
...amework/theme/components/toastr/toast.component.ts 48.64% <20%> (-12.07%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MENU] Icons from differents packs Components that accepts icon as a property should also accept pack.
2 participants