Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): add missing show header input #1889

Merged
merged 3 commits into from
Aug 29, 2019
Merged

fix(datepicker): add missing show header input #1889

merged 3 commits into from
Aug 29, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Aug 8, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1833

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #1889 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1889      +/-   ##
==========================================
+ Coverage   84.07%   84.07%   +<.01%     
==========================================
  Files         234      234              
  Lines        7724     7726       +2     
  Branches      680      680              
==========================================
+ Hits         6494     6496       +2     
  Misses       1032     1032              
  Partials      198      198
Impacted Files Coverage Δ
...heme/components/datepicker/datepicker.component.ts 90.21% <100%> (+0.1%) ⬆️

@yggg yggg requested a review from nnixaa August 29, 2019 11:16
@yggg yggg merged commit d265991 into akveo:master Aug 29, 2019
@yggg yggg deleted the fix/picker-add-show-header branch August 29, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbDatePicker with showHeader=false
2 participants