Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(checkbox): deprecate value, add checked, don't emit of i… #1585

Merged
merged 6 commits into from
Jun 14, 2019

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented Jun 6, 2019

…nput change

Closes #1478

@nnixaa nnixaa requested a review from yggg June 6, 2019 08:00
@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #1585 into master will increase coverage by <.01%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master    #1585      +/-   ##
==========================================
+ Coverage   83.29%   83.29%   +<.01%     
==========================================
  Files         231      231              
  Lines        7535     7543       +8     
  Branches      658      658              
==========================================
+ Hits         6276     6283       +7     
- Misses       1068     1069       +1     
  Partials      191      191
Impacted Files Coverage Δ
...rk/theme/components/checkbox/checkbox.component.ts 98.27% <93.75%> (-1.73%) ⬇️

@nnixaa nnixaa requested a review from yggg June 7, 2019 08:19
@yggg yggg merged commit 72cc999 into master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nb-checkbox (change) event.returnValue is always true in FireFox.
2 participants