Refactor/overlay components #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yggg
reviewed
Aug 29, 2018
| @Inject(NB_WINDOW) protected window, | ||
| @Inject(NB_DOCUMENT) protected document, | ||
| @Inject(PLATFORM_ID) protected platformId: Object, | ||
| protected layoutDirectionService: NbLayoutDirectionService, | ||
| protected scrollService: NbLayoutScrollService, | ||
| protected rulerService: NbLayoutRulerService, | ||
| protected scrollTop: NbRestoreScrollTopHelper, | ||
| @Optional() protected overlayContainer: NbOverlayContainerAdapter, |
yggg
reviewed
Aug 29, 2018
nnixaa
requested changes
Sep 10, 2018
| * Basic menu items, will be passed to the internal NbMenuComponent. | ||
| * */ | ||
| @Input('nbContextMenu') | ||
| set _items(items: NbMenuItem[]) { |
| @@ -10,6 +10,9 @@ import { NbDynamicToAddComponent } from '../shared/dynamic.component'; | |||
| @Component({ | |||
| selector: 'nb-popover-custom-component', | |||
| templateUrl: './popover-custom-component.component.html', | |||
| styles: [`nb-layout-column { | |||
| @@ -10,6 +10,10 @@ import { Component } from '@angular/core'; | |||
| @Component({ | |||
| selector: 'nb-popover-showcase', | |||
| templateUrl: './popover-showcase.component.html', | |||
| styles: [`:host { | |||
nnixaa
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Refactor popover, context-menu, and searches, implement with overlays.
Remove capability add something to layout top. All dynamic layout components have to work with overlays now.
BREAKING CHANGE:
appendToLayoutTopandclearLayoutTopmethods was removed fromNbThemeService. Instead of this methods, you have to useNbOverlayService. It's the extension of @angular/cdk overlays, so, check documentation first of all.Basic usage of overlays may look like this:
Closes #683, closes #664, closes #668.