Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update popover according to new overlays #664

Closed
1 of 2 tasks
nnixaa opened this issue Aug 23, 2018 · 0 comments · Fixed by #684
Closed
1 of 2 tasks

Update popover according to new overlays #664

nnixaa opened this issue Aug 23, 2018 · 0 comments · Fixed by #684
Assignees
@Tibing
Labels
enhancement module:theme
Milestone
2.0.0

Comments

@nnixaa
Copy link
Collaborator

nnixaa commented Aug 23, 2018

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description
@nnixaa nnixaa added this to the 2.0.0 milestone Aug 23, 2018
@Tibing Tibing mentioned this issue Aug 28, 2018
Merged
2 tasks
nnixaa pushed a commit that referenced this issue Sep 10, 2018
@tibing-old-email @nnixaa
refactor(theme): refactor popover, context-menu and search components…
d3ba6ab 
… to use overlays (#684)

Refactor popover, context-menu, and search, implement with overlays.
Remove capability add something to layout top. All dynamic layout components have to work with overlays now.

BREAKING CHANGE:
`appendToLayoutTop` and `clearLayoutTop` methods was removed from `NbThemeService`. Instead of this methods, you have to use `NbOverlayService`. It's the extension of @angular/cdk overlays, so, check [documentation](https://material.angular.io/cdk/overlay/overview) first of all. 

Basic usage of overlays may look like this:

```ts
constructor(protected overlay: NbOverlayService) {
}

const overlayRef = overlay.create();
const overlayComponentPortal = new ComponentPortal(MyOverlayComponent);
overlayRef.attach(overlayComponentPortal);
```

Closes #683, closes  #664, closes #668.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tibing Tibing

Labels
enhancement module:theme
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Refactor/overlay components Tibing/nebular
2 participants
@nnixaa @Tibing