-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style conflicts with DevExtreme #561
Labels
Comments
Hey @EatonZ, this is clearly a bug in the Nebular tabs. Thanks for the report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue type
I'm submitting a ... (check one with "x")
Issue description
Current behavior:
Nebular styles are bleeding into a 3rd party component, the DevExtreme Data Grid.
Expected behavior:
Nebular styles should not be influencing the look and behavior of the grid at all. This page states 3rd party components are encouraged, so this doesn't seem like something that should be happening.
I did try Shadow DOM to isolate the grid, and that did solve the issue, but it turns out the grid isn't compatible with Shadow DOM (scrolling breaks), so it was only half a fix.
Steps to reproduce:
Run the sample. Inspect element down to this and you can see Nebular is erroneously adding padding and fonts to a non-Nebular element:
Related code:
I put together a sample for you. Download and run in your favorite IDE.
Sample.zip
It looks like the problematic Nebular styling is here.
Important Note:
There may be other styling issues with Nebular and DevExtreme components. This is just one example of a visible issue, but there may be more that could be affecting the components in hidden ways.
Other information:
npm: 6.1.0
node: 10.6.0
Browser: Chrome 67 on Windows 10 1803
Angular: 6.0.9
Nebular: 2.0.0-rc.9
The text was updated successfully, but these errors were encountered: