fix(menu): trigger change detection after setting max-height #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To animate menu expanding we need to know height of all expoanded children. Since children cann't be accessed before AfterViewInit hook, we have to calc and set 'maxHeight' there, but it causing ExpressionChangedAfterItHasBeenCheckedError error. Since 'maxHeight' can't be calculated earlier, we have to trigger change detection again. This is a common workaround for this error.
nnixaa
approved these changes
Apr 5, 2018
|
@yggg 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To animate menu expanding we need to know height of all expoanded children.
Since children cann't be accessed before AfterViewInit hook, we have to calc
and set 'maxHeight' there, but it causing ExpressionChangedAfterItHasBeenCheckedError
error. Since 'maxHeight' can't be calculated earlier, we have to trigger change detection
again. This is a common workaround for this error.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Fix #263