Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu: error when navigating to page without menu and then back to previous page #263

Closed
1 of 2 tasks
nnixaa opened this issue Feb 22, 2018 · 4 comments · Fixed by #349
Closed
1 of 2 tasks

Menu: error when navigating to page without menu and then back to previous page #263

nnixaa opened this issue Feb 22, 2018 · 4 comments · Fixed by #349
Assignees
@yggg
Labels
bug module:theme P2: important

Comments

@nnixaa
Copy link
Collaborator

nnixaa commented Feb 22, 2018

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

Current behavior:

throws error
image

Expected behavior:

no error
Steps to reproduce:

on ngx-admin

  1. go the dashboard
  2. open auth menu
  3. click on login page
  4. fill the form, click on login
  5. get redirected to the dashboard with the error in the browser console

Angular, Nebular

<!--
Check your `package-lock.json` or locate a `package.json` in the `node_modules` folder.
-->

nebular rc5, rc6
@nnixaa
Copy link
Collaborator Author

nnixaa commented Feb 22, 2018

@yggg when you have a spare minute

@prmces
Copy link

prmces commented Feb 28, 2018

Hello Guys!!!

Just an FYI I had the same issues testing the starter-kit.

When navigating to any auth page, and with a browser back, that error appear.

Maybe would be good to have close butttons for the login pages...

Cya

Paulo

@nnixaa
Copy link
Collaborator Author

nnixaa commented Mar 26, 2018

akveo/ngx-admin#1587

@nnixaa nnixaa mentioned this issue Mar 26, 2018
Closed
3 tasks
@nnixaa
Copy link
Collaborator Author

nnixaa commented Apr 2, 2018

akveo/ngx-admin#1615

@yggg yggg mentioned this issue Apr 5, 2018
Merged
1 task
nnixaa pushed a commit that referenced this issue Apr 5, 2018
@yggg @nnixaa
fix(menu): trigger change detection after setting max-height (#349)
8c10372 
Closes #263 
To animate menu expanding we need to know a height of all expanded children.
Since children can't be accessed before AfterViewInit hook, we have to calc
and set 'maxHeight' there, but it causing ExpressionChangedAfterItHasBeenCheckedError
error. Since 'maxHeight' can't be calculated earlier, we have to trigger change detection
again. This is a common workaround for this error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yggg yggg

Labels
bug module:theme P2: important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(menu): trigger change detection after setting max-height
3 participants
@nnixaa @yggg @prmces