Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nebular-icons as dependency to @nebular/theme #195

Closed
1 of 2 tasks
elupanov opened this issue Feb 8, 2018 · 0 comments · Fixed by #749
Closed
1 of 2 tasks

Add nebular-icons as dependency to @nebular/theme #195

elupanov opened this issue Feb 8, 2018 · 0 comments · Fixed by #749
Assignees
@Tibing
Labels
bug module:theme
Milestone
2.0.0

Comments

@elupanov
Copy link
Member

elupanov commented Feb 8, 2018

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

Current behavior:
Search component uses nebular icons. But nebular/theme doesn't have icons as dependency

Expected behavior:
Add nebular-icons as dependency

Other information:

npm, node, OS, Browser

<!--
Node, npm: `node 8.9.4` and `npm 5.6.0`
OS: Windows 10
Browser: Chrome
-->

Angular, Nebular

Nebular 2.0.0-rc.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tibing Tibing

Labels
bug module:theme
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

fix(theme): add nebular icons as peer dependency Tibing/nebular
3 participants
@nnixaa @elupanov @Tibing