Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nb-tabset may optionally use hidden elements instead of ng-template #144

Closed
burton-scalefastr opened this issue Jan 17, 2018 · 2 comments · Fixed by #227
Closed

nb-tabset may optionally use hidden elements instead of ng-template #144

burton-scalefastr opened this issue Jan 17, 2018 · 2 comments · Fixed by #227

Comments

@burton-scalefastr
Copy link

I have some iframes that I want pre-rendered so that when the user selects the second and 3rd tab, they're ready go to.

Right now that's not possible because the content isn't in the dom and the iframe isn't loaded until the tab is changed.

@nnixaa
Copy link
Collaborator

nnixaa commented Jan 17, 2018

@burton-scalefastr good point for such cases. Though sometimes we explicitly do not want to load the content (from the performance standpoint). I would suggest making it optional.

@nnixaa nnixaa changed the title nb-tabset should use hidden elements , not template nb-tabset may optionally use hidden elements instead of ng-template Jan 17, 2018
@burton-scalefastr
Copy link
Author

I'd kill to have it optional now. Re-loading the iframes is really hurting performance and I"ll have to rework everything to use my own charting library.. but it's not the end of the world I imagine.

@nnixaa nnixaa added this to the rc.6 milestone Jan 22, 2018
@nnixaa nnixaa added the WIP label Feb 13, 2018
nnixaa added a commit that referenced this issue Feb 13, 2018
nnixaa added a commit that referenced this issue Feb 13, 2018
dimaatkaev pushed a commit to dimaatkaev/nebular that referenced this issue Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants