Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set skipLocationChange for NbMenuItem #1028

Closed
1 task
maihannijat opened this issue Nov 29, 2018 · 3 comments · Fixed by #1043
Closed
1 task

Add option to set skipLocationChange for NbMenuItem #1028

maihannijat opened this issue Nov 29, 2018 · 3 comments · Fixed by #1043

Comments

@maihannijat
Copy link
Contributor

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • [ x] feature request

Issue description

Current behavior:
There is no option to set skipLocationChange for menu item. Users see in the address bar the link of the menu item clicked.

Expected behavior:
Add option for skipping location, and user will set true or false.

{
  title: 'New Field',
  icon: 'nb-compose',
  link: '/mylink',
  location: false
}
@Tibing
Copy link
Member

Tibing commented Nov 30, 2018

Hi @maihannijat, thanks for submitting a feature request. If you want to help us improve Nebular, please, feel free to submit a pull request 😄

@maihannijat
Copy link
Contributor Author

@Tibing I am trying to push my changes but getting the following error:

remote: Permission to akveo/nebular.git denied to maihannijat.
fatal: unable to access 'https://github.com/akveo/nebular.git/': The requested URL returned error: 403
win-macmini:nebular-master myuser$ git push menu-skip-location menu-skip-location
fatal: 'menu-skip-location' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I followed the CONTRIBUTING.md . Also, I want to change the API of this section : https://akveo.github.io/nebular/docs/components/menu/api#nbmenucomponent. How can I do that?

@Tibing
Copy link
Member

Tibing commented Dec 3, 2018

@maihannijat, you have to fork our repo and send us pull request from your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants