Add option to quote the command sent to the terminal #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This added setting is ment to put the command sent to the terminal buffer in quote. This is for compatibility with git bash in Windows where the way neovim sends the command is using
bash -c <cmd>without putting the whole command in quotes errors are raised due tounknown command.I tested this new process under my work windows machine. Toggleterm is now able to open the terminal without problem. Even custom terminals.
I did some regression test on my linux desktop and without providing the new
quote_command. The behavior stayed the same.