Kernel/SysFS: Remove unnecessary mutex lockers in SysFS metadata getters

SysFS inodes have immutable metadata once created.
akimdi · Aug 28, 2021 · 244ede5 · 244ede5
1 parent 8ebf08b
commit 244ede5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Kernel/FileSystem/SysFS.cpp b/Kernel/FileSystem/SysFS.cpp
@@ -113,7 +113,7 @@ KResultOr<NonnullRefPtr<Inode>> SysFSInode::lookup(StringView)
 
 InodeMetadata SysFSInode::metadata() const
 {
- MutexLocker locker(m_inode_lock);
+ // NOTE: No locking required as m_associated_component or its component index will never change during our lifetime.
  InodeMetadata metadata;
  metadata.inode = { fsid(), m_associated_component->component_index() };
  metadata.mode = S_IFREG | S_IRUSR | S_IRGRP | S_IROTH;
@@ -179,7 +179,7 @@ SysFSDirectoryInode::~SysFSDirectoryInode()
 
 InodeMetadata SysFSDirectoryInode::metadata() const
 {
- MutexLocker locker(m_inode_lock);
+ // NOTE: No locking required as m_associated_component or its component index will never change during our lifetime.
  InodeMetadata metadata;
  metadata.inode = { fsid(), m_associated_component->component_index() };
  metadata.mode = S_IFDIR | S_IRUSR | S_IRGRP | S_IROTH | S_IXOTH;